Review Request 120832: Fix build with gcc-4.9

[Heiko Becker]

> On Okt. 28, 2014, 1:41 nachm., Evan Teran wrote:
> > Ship It!
> 
> Heiko Becker wrote:
>     I don't have commit access, so I need somebody to push this for me. Thanks in advance.
> 
> Christoph Feck wrote:
>     Are you sure you only need it in the frameworks branch? I would rather like to commit it to master for the coming 14.12 release, or KDE/4.14 branch even.

Well, it seems gcc-4.9 alone is only one part of the build failure, the other is extra-cmake-modules passing std=c++0x to the build. Which isn't specified as default for 4.14 and 14.12.
So, yes it doesn't hurt and potentially helps if someone passes std=c++0x/11, but since I don't have commit access I would leave it to the one pushing this. Or is a separate review request required?


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120832/#review69281
-----------------------------------------------------------


On Okt. 27, 2014, 9:03 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120832/
> -----------------------------------------------------------
> 
> (Updated Okt. 27, 2014, 9:03 nachm.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> From https://gcc.gnu.org/gcc-4.9/porting_to.html:
> "The <cstddef> header was updated for C++11 support and this breaks
> some libraries which misuse macros meant for internal use by GCC
> only. For instance with GMP versions up to 5.1.3, you may see:
> 
> /usr/include/c++/4.9.0/cstddef:51:11: error: ‘::max_align_t’ has
> not been declared using ::max_align_t;
> 
> A workaround until libraries get updated is to include <cstddef> or
> <stddef.h> before any headers from that library."
> 
> 
> Diffs
> -----
> 
>   knumber/knumber_base.h e0792d359f29b061524c216d1858d5e4f6316bdd 
> 
> Diff: https://git.reviewboard.kde.org/r/120832/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141029/53ba1ce8/attachment.html>