Review Request 120783: Remove KXMLGUIClient warning in Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120783/#review69136
-----------------------------------------------------------

Ship it!


Since this is a bug fix, please commit it to KDE/4.14 and merge to master with the usual parameters (`git merge --log --edit --no-ff KDE/4.14`). Note that on KDE/4.14 you'll need to add the KXMLGUIFactory include again, since it was removed when I reverted /r/120216 in that branch.

- Raphael Kubo da Costa


On Oct. 24, 2014, 6:32 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120783/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 6:32 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When Ark is run from a terminal, the following warning is displayed on exit:
> `ark(6384)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x101cf80 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.`
> 
> The warning is fixed by just removing the client from the KXMLGUIFactory, in the `Part` destructor.
> A similar fix has been done in other apps, e.g. see [Kate](https://projects.kde.org/projects/kde/applications/kate/repository/revisions/4c56004ebbc5b1edb2c94d358c623015f10a1a3d).
> 
> This was one of the two unrelated patches that were in this other [review](https://git.reviewboard.kde.org/r/120216/).
> The other one [has been already committed](http://quickgit.kde.org/?p=ark.git&a=commit&h=8fc15207c00aadeb3cee58ab68e443a7966291df) to the frameworks branch, so I guess we can ignore it for master.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/120783/diff/
> 
> 
> Testing
> -------
> 
> Compile and run Ark from Konsole. The warning is gone.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141025/906a5918/attachment.html>