Review Request 120216: Add "open-with" action and right-click context menu to Ark

[Raphael Kubo da Costa]

> On Oct. 23, 2014, 6:23 p.m., Raphael Kubo da Costa wrote:
> > Thank you for working on this! Please make sure your commit message is descriptive and explains what has been done and why (I can take a look at it if you want).
> > 
> > Useful keywords in the commit message: "FEATURE" (instead of "BUG"), "GUI" and "DIGEST".
> 
> Elvis Angelaccio wrote:
>     What about the following message?
>     
>     Add the 'open-with' action and show the right-click menu.
>     
>     This patch implements the 'open-with' action, which allows the users to temporarily extract a file and open it with a chosen application.
>     A contextual menu has been implemented as well. This menu is showed when the user right-clicks on an entry in the archive.
>     
>     FEATURE: 179066
>     GUI: a new action and a new menu are now availables.
>     DIGEST:

Looking at https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages I don't think "GUI" takes any parameters, and you could check if "FIXED-IN" works with "FEATURE". Other than that, ship it!


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120216/#review69015
-----------------------------------------------------------


On Oct. 23, 2014, 5:58 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120216/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 5:58 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 179066
>     http://bugs.kde.org/show_bug.cgi?id=179066
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This review aims to bring life to this 2 years-old review: https://git.reviewboard.kde.org/r/103690/
> The patch is mostly the same, but the issues pointed by Raphael should now be fixed.
> In particular, the default Ark behavior is unchanged: when an entry is double clicked, the preview is showed (instead of launching the default application of that entry).
> 
> 
> Diffs
> -----
> 
>   part/ark_part.rc 044c11a562d03589314f05e86eb1d68e633ee35e 
>   part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/120216/diff/
> 
> 
> Testing
> -------
> 
> Open an existing archive, right-click on an entry, the context menu is showed and and the "Open With..." action is available.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141023/c1c25d1c/attachment-0001.html>