Review Request 120216: Add "open-with" action and right-click context menu to Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120216/#review68933
-----------------------------------------------------------


We're almost there, I've left a few comments on some things I overlooked in the previous review round. I guess this should be all.


part/part.cpp
<https://git.reviewboard.kde.org/r/120216/#comment48207>

    `qDeleteAll(m_previewDirList)` also works and looks cleaner.



part/part.cpp
<https://git.reviewboard.kde.org/r/120216/#comment48208>

    Given this always comes from `KTempDir`, the trailing '/' is always there, so you can just use a `const QString fullName` here.



part/part.cpp
<https://git.reviewboard.kde.org/r/120216/#comment48209>

    Note for the future: just like using `m_previewDirList.last()` here would be prone to races if we don't disable the UI while extracting, so would using `m_previewMode`.
    
    A nice improvement would be having a `PreviewJob` that maybe inherits from `ExtractJob` and has the preview mode there. It could even have a `KTempDir` itself so you don't have to do the bookkeeping of `m_previewDirList` yourself.
    
    Again, it's something to keep in mind but not essential for this Review Request (you could just add a comment with a "TODO" here or in `part.h`).


- Raphael Kubo da Costa


On Oct. 22, 2014, 1:22 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120216/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 1:22 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 179066
>     http://bugs.kde.org/show_bug.cgi?id=179066
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This review aims to bring life to this 2 years-old review: https://git.reviewboard.kde.org/r/103690/
> The patch is mostly the same, but the issues pointed by Raphael should now be fixed.
> In particular, the default Ark behavior is unchanged: when an entry is double clicked, the preview is showed (instead of launching the default application of that entry).
> 
> 
> Diffs
> -----
> 
>   part/ark_part.rc 044c11a562d03589314f05e86eb1d68e633ee35e 
>   part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/120216/diff/
> 
> 
> Testing
> -------
> 
> Open an existing archive, right-click on an entry, the context menu is showed and and the "Open With..." action is available.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141022/b79f6b5a/attachment.html>