Review Request 120216: Add "open-with" action and right-click context menu to Ark

Elvis Angelaccio elvis.angelaccio at kdemail.net
Wed Oct 22 10:19:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120216/
-----------------------------------------------------------

(Updated Ott. 22, 2014, 10:19 a.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

All the issues should be addressed now.
- The patch is now built upon master.
- I've removed the unrelated patches. It really makes sense to put them in their own review request, I'll do it later.


Bugs: 179066
    http://bugs.kde.org/show_bug.cgi?id=179066


Repository: ark


Description
-------

This review aims to bring life to this 2 years-old review: https://git.reviewboard.kde.org/r/103690/
The patch is mostly the same, but the issues pointed by Raphael should now be fixed.
In particular, the default Ark behavior is unchanged: when an entry is double clicked, the preview is showed (instead of launching the default application of that entry).


Diffs (updated)
-----

  part/ark_part.rc 044c11a562d03589314f05e86eb1d68e633ee35e 
  part/part.h 5379b9fc1aaa4ce451c8b1745ca46ee78630b005 
  part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 

Diff: https://git.reviewboard.kde.org/r/120216/diff/


Testing
-------

Open an existing archive, right-click on an entry, the context menu is showed and and the "Open With..." action is available.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141022/5a738deb/attachment.html>


More information about the Kde-utils-devel mailing list