Review Request 120783: Remove KXMLGUIClient warning in Ark

[Boris Egorov]

> On Nov. 24, 2014, 2:32 p.m., Boris Egorov wrote:
> > This patch can crash Ark on nested archives. If you open debian archive and nested archive inside it and then close both Ark windows, it crashes.
> 
> Raphael Kubo da Costa wrote:
>     Already fixed: https://bugs.kde.org/show_bug.cgi?id=341187 http://quickgit.kde.org/?p=ark.git&a=commit&h=9c30f30b38c36a31e6fcb3aa047a0247ac5a22fb

Ah, good to know.

Debian package takes changes from this patch, but not from bug 341187. Will report against Debian package then.


- Boris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120783/#review70850
-----------------------------------------------------------


On Oct. 25, 2014, 1:13 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120783/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 1:13 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When Ark is run from a terminal, the following warning is displayed on exit:
> `ark(6384)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x101cf80 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.`
> 
> The warning is fixed by just removing the client from the KXMLGUIFactory, in the `Part` destructor.
> A similar fix has been done in other apps, e.g. see [Kate](https://projects.kde.org/projects/kde/applications/kate/repository/revisions/4c56004ebbc5b1edb2c94d358c623015f10a1a3d).
> 
> This was one of the two unrelated patches that were in this other [review](https://git.reviewboard.kde.org/r/120216/).
> The other one [has been already committed](http://quickgit.kde.org/?p=ark.git&a=commit&h=8fc15207c00aadeb3cee58ab68e443a7966291df) to the frameworks branch, so I guess we can ignore it for master.
> 
> 
> Diffs
> -----
> 
>   part/part.cpp 09fe1cbfcc7f4345fe12932055dcb041f50abb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/120783/diff/
> 
> 
> Testing
> -------
> 
> Compile and run Ark from Konsole. The warning is gone.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141124/c15ecc2f/attachment.html>