Review Request 118108: Do not crash when closing during large archive loading
Raphael Kubo da Costa
rakuco at FreeBSD.org
Wed May 14 22:55:47 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118108/#review57950
-----------------------------------------------------------
Ship it!
Thanks <3
Please commit to KDE/4.13 and merge into master.
- Raphael Kubo da Costa
On May 15, 2014, 1:53 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118108/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 1:53 a.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Bugs: 193908
> http://bugs.kde.org/show_bug.cgi?id=193908
>
>
> Repository: ark
>
>
> Description
> -------
>
> Track running jobs in JobTracker. On its destruction (i.e. UI is going down) we kill and delete (which waits for finishing) those jobs.
>
>
> Diffs
> -----
>
> kerfuffle/cliinterface.h 7d78b4a
> kerfuffle/cliinterface.cpp 3e835b8
> kerfuffle/jobs.cpp aedc62c
> part/jobtracker.h 356a558
> part/jobtracker.cpp 15a7764
> plugins/libarchive/libarchivehandler.h 9ec7541
> plugins/libarchive/libarchivehandler.cpp cd473ee
>
> Diff: https://git.reviewboard.kde.org/r/118108/diff/
>
>
> Testing
> -------
>
> Tested with very big tar.gz (libarchive plugin) and .zip (cliplugin) and it closes without crashing now
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140514/661ab7be/attachment.html>
More information about the Kde-utils-devel
mailing list