Review Request 118108: Do not crash when closing during large archive loading
Albert Astals Cid
aacid at kde.org
Wed May 14 21:48:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118108/
-----------------------------------------------------------
(Updated May 14, 2014, 9:48 p.m.)
Review request for KDE Utils and Raphael Kubo da Costa.
Changes
-------
Try to fix rkcosta's assert i can't reproduce
Bugs: 193908
http://bugs.kde.org/show_bug.cgi?id=193908
Repository: ark
Description
-------
Track running jobs in JobTracker. On its destruction (i.e. UI is going down) we kill and delete (which waits for finishing) those jobs.
Diffs (updated)
-----
kerfuffle/cliinterface.h 7d78b4a
kerfuffle/cliinterface.cpp 3e835b8
kerfuffle/jobs.cpp aedc62c
part/jobtracker.h 356a558
part/jobtracker.cpp 15a7764
plugins/libarchive/libarchivehandler.h 9ec7541
plugins/libarchive/libarchivehandler.cpp cd473ee
Diff: https://git.reviewboard.kde.org/r/118108/diff/
Testing
-------
Tested with very big tar.gz (libarchive plugin) and .zip (cliplugin) and it closes without crashing now
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140514/df35a1ad/attachment.html>
More information about the Kde-utils-devel
mailing list