Review Request 121342: Switch away from libarchive deprecated functions

[Ivailo Monev]

> On Дек. 4, 2014, 9:28 след обяд, Raphael Kubo da Costa wrote:
> > This means Ark won't built with libarchive 2.8 anymore, right? If so, I'd rather do it for frameworks and leave the KDE4 version supporting a wider range of libarchive releases.
> 
> Elvis Angelaccio wrote:
>     Yes, that's right. Should I commit on `frameworks` then?
> 
> Raphael Kubo da Costa wrote:
>     I think we can do a broader API update here. For example, that same wiki page says the `ARCHIVE_COMPRESSION_*` macros are not part of libarchive3 (I still have them defined here for compatibility, though), so there's room for more improvements.
> 
> Elvis Angelaccio wrote:
>     That's fine for me. Feel free to discard this review, it makes sense to create a new one later.
> 
> Raphael Kubo da Costa wrote:
>     I'm fine with updating this review once you have the bandwidth to work on it instead of opening a new one, after all my suggestion is just an extension of the original idea behind this patch.

You need to update the FindLibArchive cmake module to look for the new API too.


- Ivailo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121342/#review71369
-----------------------------------------------------------


On Дек. 22, 2014, 11:13 преди обяд, Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121342/
> -----------------------------------------------------------
> 
> (Updated Дек. 22, 2014, 11:13 преди обяд)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch replaces the deprecated `libarchive` functions used in `libarchivehandler.cpp` with their replacements.
> Quick reference: https://github.com/libarchive/libarchive/wiki/ManPageLibarchiveChanges3#Deprecated_Symbols
> 
> 
> Diffs
> -----
> 
>   plugins/libarchive/libarchivehandler.cpp 0fba52864523bf07ba8c898aa6b15cd867001de6 
> 
> Diff: https://git.reviewboard.kde.org/r/121342/diff/
> 
> 
> Testing
> -------
> 
> After compiling all the warnings about deprecated symbols are gone.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20141224/a12e19fb/attachment.html>