Review Request 119728: Clear the window when all the wallets are deleted
Arjun Ak
arjunak234 at gmail.com
Fri Aug 22 09:57:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119728/
-----------------------------------------------------------
(Updated Aug. 22, 2014, 9:57 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Utils and Valentin Rusu.
Repository: kwalletmanager
Description
-------
Even after deleting the last wallet, its title and icon will still be shown in the main window (see screenshots). This patch fixes this issue by hiding the widget when the wallet list is empty.
I'm not sure if it should be done here, Isn't it KPageWidget's responsibility to clean up the widget? Should this be moved to kdelibs?
Diffs
-----
src/manager/kwalletmanagerwidget.cpp cecbf6a
Diff: https://git.reviewboard.kde.org/r/119728/diff/
Testing
-------
File Attachments
----------------
After
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/f4d5ac28-65b9-4691-8b5d-7746376aa0a4__after.png
Before
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/8086d9c3-e7f9-4519-9060-c269822a00a3__before.png
Thanks,
Arjun Ak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140822/c8c732d9/attachment.html>
More information about the Kde-utils-devel
mailing list