Review Request 110672: Allow multiple selection in archiveview

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110672/#review64656
-----------------------------------------------------------



part/part.cpp
<https://git.reviewboard.kde.org/r/110672/#comment45223>

    You can replace this loop with something like this:
    
        const int lastPathDelimiterPos = rootStr.lastIndexOf(QLatin1Char('/'), rootstr_len);
        rootStr.truncate(lastPathDelimiterPos);
    
    (I'm assuming there will be at least a "/" in the beginning of all nodes, otherwise you have to account for that)


Thanks for the patch; I still need to take a deeper look at it (and check some assumptions such as whether all nodes always have a common '/' parent or not), so I just left one inline comment so far.

In any case, this is the sort of code I'd expect to find in the model-view part itself, not here in part.cpp (doing this would also make it easier to test). And please adjust the coding style: Ark follows kdelibs', which means ending each sentence in a period, using `fooBar` instead of `foo_bar` in variable and function names, putting a space between `if` and `(`, not needlessly abbreviating variable names etc.

- Raphael Kubo da Costa


On Aug. 16, 2014, 11:13 a.m., Alim Gokkaya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110672/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 11:13 a.m.)
> 
> 
> Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.
> 
> 
> Diffs
> -----
> 
>   part/archiveview.cpp 6b9918d 
>   part/part.cpp b4ebcd2 
> 
> Diff: https://git.reviewboard.kde.org/r/110672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alim Gokkaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140816/6e53c52d/attachment.html>