Review Request 110672: Allow multiple selection in archiveview

Albert Astals Cid aacid at kde.org
Sat Aug 16 14:59:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110672/#review64644
-----------------------------------------------------------


You know what would be awesome? An autotest, do you know how to use qtest? Do you think you could craft an autotest to test this? This way even it'd be easier to approve this. If not, i can try crafting one myself, since honestly after the previous fiasco i don't feel confortable approving this "relatively big" change in a code i don't know much.

- Albert Astals Cid


On ago. 16, 2014, 8:13 a.m., Alim Gokkaya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110672/
> -----------------------------------------------------------
> 
> (Updated ago. 16, 2014, 8:13 a.m.)
> 
> 
> Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.
> 
> 
> Diffs
> -----
> 
>   part/archiveview.cpp 6b9918d 
>   part/part.cpp b4ebcd2 
> 
> Diff: https://git.reviewboard.kde.org/r/110672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alim Gokkaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140816/5e7220a5/attachment.html>


More information about the Kde-utils-devel mailing list