Review Request 118956: Fix bug 329053 - kwalletmanager segfaults when trying to delete a wallet

Valentin Rusu kde at rusu.info
Fri Aug 8 20:43:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118956/#review64092
-----------------------------------------------------------

Ship it!


Ship It!

- Valentin Rusu


On June 26, 2014, 12:38 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118956/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 12:38 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 329053
>     http://bugs.kde.org/show_bug.cgi?id=329053
> 
> 
> Repository: kwalletmanager
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=329053
> 
> This patch:
> 
> 1. Hides the "delete wallet" action if there are no wallets.
> 2. Prevent null pointer derefence in KWalletManagerWidget::activeWalletName()
> 
> 
> Diffs
> -----
> 
>   src/manager/kwalletmanager.h 7489077 
>   src/manager/kwalletmanager.cpp 3d8ad20 
>   src/manager/kwalletmanagerwidget.cpp bd2a799 
> 
> Diff: https://git.reviewboard.kde.org/r/118956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140808/56642bb4/attachment.html>


More information about the Kde-utils-devel mailing list