Review Request 110672: Allow multiple selection in archiveview

[Albert Astals Cid]

> On ago. 7, 2014, 9:50 p.m., Raphael Kubo da Costa wrote:
> > I am sorry, but I had to revert this in commit 4429a4ebbb58f44e4c96603f6bc519da8c0ce5da because of the regressions it introduces. As I mentioned there, while this appears to work correctly for ZIP and LHA archives, it can fail for libarchive (e.g. tar archives) and RAR.
> > 
> > For example, if I open phonon-4.7.2.tar.xz, select declarative/abstractinitable.h, doc/BUGS, doc/IDEAS and phonon.pc.cmake and drag phonon.pc.cmake, I end up with "on.pc.cmake", "arative/abstractinitable.h", "IDEAS" and "BUGS". If I drag everything via declarative/abstractinitable.h, I end up with only "abstractinitable.h" (no directory structure) and "ake".
> > 
> > Alim: I deeply apologize for the lack of response in this review request, I've just been busy with a lot of other projects in my paid and free time. If you send another patch that addresses these problems, or need to discuss them, I'll do my best to answer in a more timely manner.
> > 
> > Albert: Thank you again for the interest in committing these long-standing review requests and fixing these annoying bugs with a lot of votes, but please at least ping me first and/or do some testing before pushing.

Well when I added you to this review I was pinging you, you got a mail, consider yourself pinged.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110672/#review64021
-----------------------------------------------------------


On ago. 6, 2014, 10:24 p.m., Alim Gokkaya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110672/
> -----------------------------------------------------------
> 
> (Updated ago. 6, 2014, 10:24 p.m.)
> 
> 
> Review request for KDE Utils, Albert Astals Cid and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch enables extracting multiple files using drag&drop by removing the code that singles the selection.
> 
> 
> Diffs
> -----
> 
>   part/archiveview.cpp 6b9918d 
>   part/part.cpp b4ebcd2 
> 
> Diff: https://git.reviewboard.kde.org/r/110672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alim Gokkaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140807/4b7af300/attachment.html>