Review Request 111625: Fix unrar 5 support

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111625/#review40374
-----------------------------------------------------------


This review has been submitted with commit 6d8bd57bbd5d1fcf8a8f0d3160f7a6a2153b1e47 by Christoph Feck to branch KDE/4.11.

- Commit Hook


On Sept. 6, 2013, 12:14 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111625/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 12:14 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> This patch adds support for the current unrar 5 betas (tested with beta 8). Review request added to get feedback:
> 
> - is the API addition okay? The other possible solution would be to signal "eof" somehow
> - should the v5 mode be a separate state? I currently use a bool flag
> 
> 
> This addresses bug 319303.
>     http://bugs.kde.org/show_bug.cgi?id=319303
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.h b76f5a2 
>   kerfuffle/cliinterface.cpp 79ae085 
>   plugins/clirarplugin/cliplugin.h 9f95563 
>   plugins/clirarplugin/cliplugin.cpp 6867e65 
> 
> Diff: http://git.reviewboard.kde.org/r/111625/diff/
> 
> 
> Testing
> -------
> 
> Tested with rar 3.x/4.x archives, including:
> - password protected listing
> - password protected files
> - multi-volume archives
> 
> I did not test archives created by rar 5.x
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130919/7f7cdff2/attachment.html>