Review Request 111318: Solution to the #319663 bug

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111318/#review35294
-----------------------------------------------------------


Please see http://quickgit.kde.org/?p=ark.git&a=commit&h=c7af2d6372ea2b222e1af223b3fd53cdeb1f3c2b -- that same line was deliberately removed from failOperation() because it caused other problems.

Looking at the commit message, however, the cases that were troublesome always involved the process having actually being successfully launched in the first place. The executable not being found is an exceptional case, and it would probably make sense to emit finished() before returning false in CliInterface::runProcess() itself. Can you try that approach and see if it works?

- Raphael Kubo da Costa


On June 29, 2013, 11:02 p.m., Ádám István Mózes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111318/
> -----------------------------------------------------------
> 
> (Updated June 29, 2013, 11:02 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Alerts if some dependencies are missing, instead of hanging.
> 
> 
> This addresses bug 319663.
>     http://bugs.kde.org/show_bug.cgi?id=319663
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.cpp 3cbe31b 
> 
> Diff: http://git.reviewboard.kde.org/r/111318/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ádám István Mózes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130630/86afd56f/attachment.html>