Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only last by account name
Rolf Eike Beer
kde at opensource.sf-tec.de
Wed Jun 5 20:56:09 UTC 2013
> This change has been marked as submitted.
I have pushed this, so we have this in before feature freeze for sure. There
are some minor nitpicks I have (besides the small changes I made to your diff
already). Please send a patch on top of current master branch so we can get
them fixed, too:
-I wonder what happens to emails like foo.bar at example.com with TLDfirst, the
regex will split them into foo, bar, example, com AFAICT, which would screw up
sorting, no?
-for an unknown reason the items added in the ui file are ignored, they only
appear when added again in C++.
-when the setting is changed and Accept or OK is clicked keysmanager will not
refresh it's display. You should probably call something like invalidateFilter
on the filter model used for the main view.
Thanks for your contribution!
Greetings,
Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130605/d6d9e415/attachment.sig>
More information about the Kde-utils-devel
mailing list