Review Request 111509: Use math.h instead of cmath.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111509/#review36003
-----------------------------------------------------------


This review has been submitted with commit 6f8c665a1ac91d636d219d8b2e8fce28b3f22ad7 by Raphael Kubo da Costa to branch KDE/4.11.

- Commit Hook


On July 14, 2013, 10:13 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111509/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 10:13 p.m.)
> 
> 
> Review request for KDE Utils, Kurt Hindenburg, Evan Teran, and Vadim Zhukov.
> 
> 
> Description
> -------
> 
> Also known as "let's try to prevent the #ifdef madness before it grows too
> wild".
> 
> `isinf' and `isnan' are macros in C99, are not mentioned in C++03 and are
> regular functions in C++11 (some C++ standard libraries such as GNU's
> libstdc++ do implement those functions in C++98 and C++03 mode).
> 
> Simplify the current checks by unconditionally using math.h instead: this
> allows us not to care about whether the `std' namespace is required and
> assumes both `isinf' and `isnan' are macros, which are implemented when
> undefined.
> 
> 
> This addresses bug 320803.
>     http://bugs.kde.org/show_bug.cgi?id=320803
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e20bd410d4f1b7201aef2d1e1f294c742f78de92 
>   knumber/knumber_float.cpp 51eaa8884ce522dcada3e963c47fadfcdc8af445 
> 
> Diff: http://git.reviewboard.kde.org/r/111509/diff/
> 
> 
> Testing
> -------
> 
> Built fine on FreeBSD with both libc++ and libstdc++. Testing on OpenBSD and OS X are appreciated.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130715/43ea2ea2/attachment.html>