Review Request 111315: Improved: Sort email addresses in main list by TLD first, then domain, and only last by account name

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111315/#review35549
-----------------------------------------------------------


This review has been submitted with commit 96cae55d37f28ce7e36919d81175825a5f3186c9 by Rolf Eike Beer on behalf of Thomas Fischer to branch master.

- Commit Hook


On July 1, 2013, 5:48 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111315/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 5:48 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Further improvements continuing the work started in review request 109847.
> 
> Addressing comments by Rolf Eike Beer (dakon):
> 
> > I wonder what happens to emails like foo.bar at example.com with TLDfirst, the
> > regex will split them into foo, bar, example, com AFAICT, which would screw
> > up sorting, no?
> I rewrote this case, should work better now, too.
> The patch contains some minor rewrites for the other cases as well plus some unifications in the white spaces.
> 
> > For an unknown reason the items added in the ui file are ignored, they only 
> > appear when added again in C++.
> No idea either.
> 
> > When the setting is changed and Accept or OK is clicked keysmanager will not
> > refresh it's display. You should probably call something like invalidateFilter
> > on the filter model used for the main view.
> Observed as well. How do I trigger such a refresh/invalidation? The settings/options class do no see the model (or the view) directly as far as I can see...
> 
> 
> Diffs
> -----
> 
>   model/keylistproxymodel.cpp cecb836 
> 
> Diff: http://git.reviewboard.kde.org/r/111315/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130703/0d615047/attachment.html>