Review Request: Don't delete the KPart in the MainWindow destructor

[Rex Dieter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107635/#review24766
-----------------------------------------------------------


you didn't mention any testing done, was curious if you had tested it to ensure there weren't any ill side-effects like what happened with okular's similar change?

- Rex Dieter


On Dec. 8, 2012, 6:09 p.m., Sandro Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107635/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 6:09 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Don't delete the KPart in the MainWindow destructor
> Details:
> This fixes the warning
> KXMLGUIClient::~KXMLGUIClient: 0x1c77eb8 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
> which appears when closing ark.
> See also https://bugs.kde.org/show_bug.cgi?id=261538#c32
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 59efe78515f6f6b2e0cb7bba4b4794c2cf86f846 
> 
> Diff: http://git.reviewboard.kde.org/r/107635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130105/c0e269bf/attachment-0001.html>