Review Request 103254: Changing conflicting accel keys

[Albert Astals Cid]

> On Feb. 7, 2013, 9:23 p.m., Albert Astals Cid wrote:
> > I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?
> 
> Evan Teran wrote:
>     Yea, I applied the patch a long time ago, and marked https://bugs.kde.org/show_bug.cgi?id=242238 as closed. What else should be done to close the request?

You should have said
REVIEW: NUMBER
in the commit that way the review would be closed. Otherwise just the creator or an admin can close it.

I'm closing it now.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103254/#review26893
-----------------------------------------------------------


On Nov. 27, 2011, 7:08 p.m., Eike Krumbacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103254/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 7:08 p.m.)
> 
> 
> Review request for KDE Utils, Funda Wang and Evan Teran.
> 
> 
> Description
> -------
> 
> Hi!
> 
> In KCalc, there are some entries with the same accelerator key. There is:
> * Settings->&Configure
> * Menu->&Constants
> * Settings->&Constants Button
> 
> I changed them to:
> 
> KCalcConstMenu(i18n("Constan&ts")
> setText(i18n("Constants &Buttons")
> 
> Leaving Settings->Configure as it is. This one is derived from kdelibs.
> 
> It might not be needed, to change Menu->Constan&ts, but I did it anyway. 
> 
> Hope you like
> 
> Eike
> 
> 
> This addresses bug 242238.
>     http://bugs.kde.org/show_bug.cgi?id=242238
> 
> 
> Diffs
> -----
> 
>   kcalc.cpp d7a943b 
> 
> Diff: http://git.reviewboard.kde.org/r/103254/diff/
> 
> 
> Testing
> -------
> 
> Trying out all Accelerator keys. Works for me. 
> 
> 
> Thanks,
> 
> Eike Krumbacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130208/40fcfef6/attachment-0001.html>