Review Request 109847: Sort email addresses in main list by TLD first, then domain, and only last by account name

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109847/#review31710
-----------------------------------------------------------


Looks like you have forgotten to add at least one file to the diff:

kgpg/model/keylistproxymodel.cpp: In member function ‘QString KeyListProxyModelPrivate::reorderEmailComponents(const QString&) const’:
kgpg/model/keylistproxymodel.cpp:68:10: error: ‘emailSorting’ is not a member of ‘KGpgSettings’

Also from a first look I would say you should simplify the email regexes. We don't really care about the validity of the addresses in the keys here at all. So simply split them at @ and . as said in the description, and ignore whatever other characters are in between that. So if the email address is foo at example or bar at example.invalid that's fine for sorting here.

- Rolf Eike Beer


On April 7, 2013, 3:46 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109847/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 3:46 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Sort email addresses in main list by TLD first, then domain, and only last by account name.
> (1) email address is split along @ and .
> (2a) list is reversed
> (2b) list elements are joined, two elements separated by .
> 
> 
> This addresses bug 278376.
>     http://bugs.kde.org/show_bug.cgi?id=278376
> 
> 
> Diffs
> -----
> 
>   conf_ui2.ui f970cd2 
>   kgpgoptions.h e609aa8 
>   kgpgoptions.cpp 12adc56 
>   model/keylistproxymodel.cpp e91cb08 
> 
> Diff: http://git.reviewboard.kde.org/r/109847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130428/d68d3568/attachment.html>