Review Request 109953: Fix of Ark::Part::openFile().
Commit Hook
null at kde.org
Sat Apr 27 12:45:50 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109953/#review31675
-----------------------------------------------------------
This review has been submitted with commit 03b5810f1e68f13fe564b873ffdd01fe82ba6aca by Raphael Kubo da Costa on behalf of Alexandr Akulich to branch KDE/4.10.
- Commit Hook
On April 27, 2013, 9:37 a.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109953/
> -----------------------------------------------------------
>
> (Updated April 27, 2013, 9:37 a.m.)
>
>
> Review request for KDE Utils.
>
>
> Description
> -------
>
> End of Ark::Part::openFile() operate with "QScopedPointer<Kerfuffle::Archive> archive" in old way (Kerfuffle::Archive *archive). Checking "archive" after "archive.take()" leads in bug.
>
>
> This addresses bug 318306.
> http://bugs.kde.org/show_bug.cgi?id=318306
>
>
> Diffs
> -----
>
> part/part.cpp d806262
>
> Diff: http://git.reviewboard.kde.org/r/109953/diff/
>
>
> Testing
> -------
>
> Since file opened or created, window title reflected it as expected. Futhermore, "Open Recent" menu now works properly.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130427/f13e0026/attachment.html>
More information about the Kde-utils-devel
mailing list