Review Request 107635: Don't delete the KPart in the MainWindow destructor

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107635/#review30901
-----------------------------------------------------------


Do you know if it is kdelibs' intention not to delete this kind of object? Valgrind complains the pointer is still reachable with this change, and it's why it was introduced in the first place.

- Raphael Kubo da Costa


On April 10, 2013, 10:55 p.m., Sandro Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107635/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 10:55 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Don't delete the KPart in the MainWindow destructor
> Details:
> This fixes the warning
> KXMLGUIClient::~KXMLGUIClient: 0x1c77eb8 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
> which appears when closing ark.
> See also https://bugs.kde.org/show_bug.cgi?id=261538#c32
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 59efe78515f6f6b2e0cb7bba4b4794c2cf86f846 
> 
> Diff: http://git.reviewboard.kde.org/r/107635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130411/e2326c51/attachment-0001.html>