Review Request 107635: Don't delete the KPart in the MainWindow destructor

Albert Astals Cid aacid at kde.org
Wed Apr 10 22:55:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107635/
-----------------------------------------------------------

(Updated April 10, 2013, 10:55 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Description
-------

Don't delete the KPart in the MainWindow destructor
Details:
This fixes the warning
KXMLGUIClient::~KXMLGUIClient: 0x1c77eb8 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
which appears when closing ark.
See also https://bugs.kde.org/show_bug.cgi?id=261538#c32


Diffs
-----

  app/mainwindow.cpp 59efe78515f6f6b2e0cb7bba4b4794c2cf86f846 

Diff: http://git.reviewboard.kde.org/r/107635/diff/


Testing
-------


Thanks,

Sandro Mani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20130410/978586c8/attachment.html>


More information about the Kde-utils-devel mailing list