Review Request: KActivities support on Ark

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106612/#review19497
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/106612/#comment15495>

    bzip? endif neds to match if



app/mainwindow.h
<http://git.reviewboard.kde.org/r/106612/#comment15494>

    Whitespaces need to go



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/106612/#comment15493>

    It would be shorter to do m_activityResourceInstance->setUrl(url)
    
    than to delete / create new


- Ivan Čukić


On Sept. 27, 2012, 3:31 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106612/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 3:31 p.m.)
> 
> 
> Review request for KDE Utils and Ivan Čukić.
> 
> 
> Description
> -------
> 
> Adds support for KActivities on ark.
> This review request is done by my student, on the KDE Internship program. more will come.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db46703 
>   app/CMakeLists.txt ebe2ce0 
>   app/mainwindow.h 5dd7fb8 
>   app/mainwindow.cpp 59efe78 
> 
> Diff: http://git.reviewboard.kde.org/r/106612/diff/
> 
> 
> Testing
> -------
> 
> monitored the activity database to check if it was correctly updating upon opening new files.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120927/2b4cd16e/attachment.html>