Review Request: KActivities support on Ark

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106612/#review19879
-----------------------------------------------------------


Please don't ship it yet. I didn't comment before because I was waiting for Ivan to review the KActivities side. There are still many coding style issues in the current patch, and setting KActivities_FOUND via add_definitions() is wrong and not very portable across compilers -- we already have a config.h.cmake, so you just need to add a HAVE_KACTIVITIES entry there.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/106612/#comment15782>

    Not really related to this change.



CMakeLists.txt
<http://git.reviewboard.kde.org/r/106612/#comment15783>

    Not really related to this change.



app/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106612/#comment15784>

    You should link against KActivities only if it was found.



app/mainwindow.h
<http://git.reviewboard.kde.org/r/106612/#comment15785>

    Style: missing space before '{'.



app/mainwindow.h
<http://git.reviewboard.kde.org/r/106612/#comment15786>

    Style: the '#' should be the first character in the line.



app/mainwindow.h
<http://git.reviewboard.kde.org/r/106612/#comment15787>

    Ditto.



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/106612/#comment15788>

    Style: please use the Qt/kdelibs style of 4 spaces for indentation, and add a space after the comma. And 0 would be better than NULL in this case.



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/106612/#comment15790>

    Please use the Qt/kdelibs coding style here.



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/106612/#comment15789>

    Why don't you set the parent in the previous line?


- Raphael Kubo da Costa


On Oct. 2, 2012, 6:57 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106612/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 6:57 p.m.)
> 
> 
> Review request for KDE Utils and Ivan Čukić.
> 
> 
> Description
> -------
> 
> Adds support for KActivities on ark.
> This review request is done by my student, on the KDE Internship program. more will come.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db46703 
>   app/CMakeLists.txt ebe2ce0 
>   app/mainwindow.h 5dd7fb8 
>   app/mainwindow.cpp 59efe78 
> 
> Diff: http://git.reviewboard.kde.org/r/106612/diff/
> 
> 
> Testing
> -------
> 
> monitored the activity database to check if it was correctly updating upon opening new files.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20121004/b2b02abe/attachment-0001.html>