Review Request: Fix a crash in Ark

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104623/#review19750
-----------------------------------------------------------


Should this be discarted then?

- Albert Astals Cid


On April 16, 2012, 9:38 p.m., Nathan Mills wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104623/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 9:38 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> This patch fixes a crash in Ark when Ark is closed while loading a big archive by ensuring that Archive::m_iface is always the last child of Archive so that it gets deleted last. Otherwise, a Job tries to call methods on a deleted ReadOnlyArchiveInterface and the program crashes.
> 
> 
> This addresses bug 193908.
>     http://bugs.kde.org/show_bug.cgi?id=193908
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archive.h 515788f 
>   kerfuffle/archive.cpp c2c5b18 
> 
> Diff: http://git.reviewboard.kde.org/r/104623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nathan Mills
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20121002/5966ea32/attachment-0001.html>