Review Request: Add option to disable internal previewer

[Kai Uwe Broulik]

> On Oct. 23, 2012, 2:04 p.m., Kai Uwe Broulik wrote:
> > Ping? Feature Freeze is Thursday.

If there are no objections, I will push it tomorrow/Thursday.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106624/#review20743
-----------------------------------------------------------


On Sept. 28, 2012, 2:52 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106624/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 2:52 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> This patch adds a checkbox to the Settings menu of Ark to enable/disable the internal previewer.
> If the checkbox is checked (default) the behavior is like it used to (preview in previewer), if it is unchecked the file will be opened in the associated application.
> 
> This will indirectly fix Bugs 284198 and 307525. When I can open a PDF directly in Okular without having to extract it first or showing it in the dumped-down previewer, I can print it from there.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/ark.kcfg 97d2086 
>   part/ark_part.rc 044c11a 
>   part/arkviewer.h bb41472 
>   part/arkviewer.cpp 053cd1c 
>   part/part.h 5379b9f 
>   part/part.cpp d806262 
> 
> Diff: http://git.reviewboard.kde.org/r/106624/diff/
> 
> 
> Testing
> -------
> 
> I opened various ZIP files, checked and unchecked the option, and the files were opened in the previewer if enabled, or in e.g. Okular if disabled.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20121107/c8bbec54/attachment.html>