Review Request: Cab files support.

[Raphael Kubo da Costa]

> On May 10, 2012, 1:18 a.m., Raphael Kubo da Costa wrote:
> > Please commit to the master branch.

Thanks you for committing.

For future reference: I saw that you committed this patch (4ede2c074e5f622edf8333892286296f2d4e9b8b) and the one for review request 103223 (50d645ad0a2ffa53e5d032aac52b3874e816ae67) without rebasing, which ended up creating 3 useless merge commits in master. And you also did not use the REVIEW keyword in the commit message to reference the review requests you made. This all makes going through Ark's history harder.

For your next patches, please check <http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages> for how to use the REVIEW keyword in your commit messages and rebase your commits correctly on top of the current branch so these unnecessary merge commits are not created.

You now need to close your review requests manually.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103306/#review13634
-----------------------------------------------------------


On May 9, 2012, 12:13 p.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103306/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 12:13 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add read support for cab archives. Libarchive from version 3.0.0 is going to support cab files.
> 
> 
> This addresses bug 83136.
>     http://bugs.kde.org/show_bug.cgi?id=83136
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 99c9374 
>   plugins/libarchive/CMakeLists.txt 6a255f8 
>   cmake/modules/FindLibArchive.cmake 40bb40f 
> 
> Diff: http://git.reviewboard.kde.org/r/103306/diff/
> 
> 
> Testing
> -------
> 
> Witch libarchive 2.8.0 - cmake shows message "Your libarchive does not have support for cab archives. libarchive >= 3.0.0 is required for this."
> Witch libarchive 3.0.1b - cmake don't show messages. Ark open, list and extract cab files.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120510/46b5dace/attachment.html>