Review Request: Add Retry button to extraction dialog.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104869/#review13576
-----------------------------------------------------------


I see. I talked to Harald about his original commit and that was indeed his original intention. It still feels a bit weird to me, but I guess it will make more sense once Ark is fully KIO-aware.


kerfuffle/extractiondialog.cpp
<http://git.reviewboard.kde.org/r/104869/#comment10753>

    Nit: it's good to add a space after the "//" and finish the sentence with a period.



kerfuffle/extractiondialog.cpp
<http://git.reviewboard.kde.org/r/104869/#comment10754>

    I'd use an else if here, and style-wise it should go right after the brace in the previous line.


- Raphael Kubo da Costa


On May 6, 2012, 12:24 a.m., Nathan Mills wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104869/
> -----------------------------------------------------------
> 
> (Updated May 6, 2012, 12:24 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> With this patch, there will be a working Retry button on the dialog box made in ExtractionDialog::accept().
> 
> 
> Diffs
> -----
> 
>   kerfuffle/extractiondialog.cpp d9cd8c8 
> 
> Diff: http://git.reviewboard.kde.org/r/104869/diff/
> 
> 
> Testing
> -------
> 
> Compiled it and made sure that all 3 buttons output the codes I thought they would.
> 
> 
> Thanks,
> 
> Nathan Mills
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120508/f5d0d0aa/attachment.html>