Review Request: Add Retry button to extraction dialog.

Raphael Kubo da Costa rakuco at freebsd.org
Mon May 7 02:43:16 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104869/#review13523
-----------------------------------------------------------


To be honest, I don't really understand what a Retry button should do here -- this TODO item was added in commit f761cbd164c1015100d810ec3c02a60b78969891 before I started working on Ark, and even at the time it didn't seem to make much sense. If a folder already exists and you retry, it will still exist. Am I missing something obvious here?

- Raphael Kubo da Costa


On May 6, 2012, 12:24 a.m., Nathan Mills wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104869/
> -----------------------------------------------------------
> 
> (Updated May 6, 2012, 12:24 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> With this patch, there will be a working Retry button on the dialog box made in ExtractionDialog::accept().
> 
> 
> Diffs
> -----
> 
>   kerfuffle/extractiondialog.cpp d9cd8c8 
> 
> Diff: http://git.reviewboard.kde.org/r/104869/diff/
> 
> 
> Testing
> -------
> 
> Compiled it and made sure that all 3 buttons output the codes I thought they would.
> 
> 
> Thanks,
> 
> Nathan Mills
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120507/0840da1e/attachment.html>


More information about the Kde-utils-devel mailing list