Review Request: Encapsulate ArchiveDirNode::m_entries
Commit Hook
null at kde.org
Sat May 5 21:26:29 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104636/#review13490
-----------------------------------------------------------
This review has been submitted with commit 73ac5f65ddb0983c4c717ca3784054203c7b6554 by Raphael Kubo da Costa to branch KDE/4.8.
- Commit Hook
On May 5, 2012, 4:55 p.m., Nathan Mills wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104636/
> -----------------------------------------------------------
>
> (Updated May 5, 2012, 4:55 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Description
> -------
>
> This patch improves the encapsulation of ArchiveDirNode::m_entries. Now, the reference returned by entries() cannot be used for assignment. I added three other methods to set, append, and delete entries.
>
>
> Diffs
> -----
>
> part/archivemodel.cpp 8389d59
>
> Diff: http://git.reviewboard.kde.org/r/104636/diff/
>
>
> Testing
> -------
>
> I compiled Ark with this patch.
>
>
> Thanks,
>
> Nathan Mills
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120505/cebde898/attachment.html>
More information about the Kde-utils-devel
mailing list