Review Request: Fix crashes when closing ark during large archive loading. (1/4)

Michal Sciubidlo michal.sciubidlo at gmail.com
Wed Jun 20 15:25:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102903/
-----------------------------------------------------------

(Updated June 20, 2012, 3:25 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Description
-------

When ark closes fastKill signal is send to any job that is in progress.
CliInterface process it, kills process and quits.
LibArchiveInterface processEvents and quits after fastKill signal.


This addresses bug 193908.
    http://bugs.kde.org/show_bug.cgi?id=193908


Diffs (updated)
-----

  kerfuffle/archiveinterface.h 801318b 
  kerfuffle/archiveinterface.cpp 3319de0 
  kerfuffle/cliinterface.h be4f671 
  kerfuffle/cliinterface.cpp f573d5b 
  kerfuffle/jobs.cpp aedc62c 
  plugins/libarchive/libarchivehandler.h 9ec7541 
  plugins/libarchive/libarchivehandler.cpp 799e941 
  plugins/libsinglefileplugin/singlefileplugin.h 1cbce40 
  plugins/libsinglefileplugin/singlefileplugin.cpp ac5a2f5 

Diff: http://git.reviewboard.kde.org/r/102903/diff/


Testing
-------

opening tar.bz2, zip and closing ark during it. creating zip, tar.bz2.


Thanks,

Michal Sciubidlo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120620/5ab3db7c/attachment-0001.html>


More information about the Kde-utils-devel mailing list