Review Request: KCalc: JJ: Group digits in n-base mode (bin, oct, hex)

[Michael Skiba]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105427/
-----------------------------------------------------------

(Updated July 4, 2012, 12:47 p.m.)


Review request for KDE Utils and Evan Teran.


Changes
-------

Updated Diff and added Evan Teran as Reviewer.


Description
-------

Completing a JJ from KBO: Enable grouping of non-decimal numbers. I've added new options in the settings menu to allow the user to set individual grouping width.
KCalc now displays "11 1101 0110" in binary mode instead of "1111010110", the user can change that behavior to any value he or she wants for example bytewise: "11 11010110".

The user can set individual widths, which are stored for binary, octal and decimal. I've set the following defaults:
binary = 4 ['1110 1010'] 
octal  = 4 ['5323 1356']
hexadecimal = 2 ['A2 F4 C2 11'] 


This addresses bug 247151.
    http://bugs.kde.org/show_bug.cgi?id=247151


Diffs (updated)
-----

  general.ui 15bee34 
  kcalc.kcfg 6b613bd 
  kcalcdisplay.h 84c1908 
  kcalcdisplay.cpp c1c238f 

Diff: http://git.reviewboard.kde.org/r/105427/diff/


Testing
-------

Save/Restoring of saved individual values work.
Calculation and conversation is correct.


Screenshots
-----------

Grouped binary number
  http://git.reviewboard.kde.org/r/105427/s/614/
Updated settings window
  http://git.reviewboard.kde.org/r/105427/s/615/


Thanks,

Michael Skiba

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120704/9417cf03/attachment.html>