Review Request: Cab files support.

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103306/#review10210
-----------------------------------------------------------

Ship it!


Thanks for taking so long to review this one. Please commit it to master (remember to rebase your change on top of it instead of producing a useless merge commit) after fixing the comment below.


plugins/libarchive/CMakeLists.txt
<http://git.reviewboard.kde.org/r/103306/#comment8399>

    shared-mime-info only lists application/vnd.ms-cab-compressed as a valid mimetype for cab files.


- Raphael Kubo da Costa


On Dec. 1, 2011, 5:41 p.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103306/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2011, 5:41 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add read support for cab archives. Libarchive from version 3.0.0 is going to support cab files.
> 
> 
> This addresses bug 83136.
>     http://bugs.kde.org/show_bug.cgi?id=83136
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibArchive.cmake 40bb40f 
>   plugins/CMakeLists.txt 151be3c 
>   plugins/libarchive/CMakeLists.txt 18015bb 
> 
> Diff: http://git.reviewboard.kde.org/r/103306/diff/diff
> 
> 
> Testing
> -------
> 
> Witch libarchive 2.8.0 - cmake shows message "Your libarchive does not have support for cab archives. libarchive >= 3.0.0 is required for this."
> Witch libarchive 3.0.1b - cmake don't show messages. Ark open, list and extract cab files.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120129/240f5711/attachment-0001.html>