Review Request: karchive plugin extract all fix

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102960/#review10080
-----------------------------------------------------------



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102960/#comment8315>

    Why is the call to QDir::exists() needed?



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102960/#comment8316>

    QString() is sufficient (and probably cheaper).



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102960/#comment8317>

    Ditto.


- Raphael Kubo da Costa


On Jan. 25, 2012, 2:02 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102960/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2012, 2:02 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> * If no item was selected from the archive, nothing was extracted! Now it extracts everything.
> * Check if an entry is a directory and append '/' if necessary
> 
> 
> Diffs
> -----
> 
>   plugins/karchiveplugin/karchiveplugin.h 1db6e07 
>   plugins/karchiveplugin/karchiveplugin.cpp 1c42eb5 
> 
> Diff: http://git.reviewboard.kde.org/r/102960/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120126/2a4587b1/attachment.html>