Review Request: Skip over potential error messages from "df"

Raphael Kubo da Costa rakuco at freebsd.org
Mon Jan 9 13:19:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103633/#review9659
-----------------------------------------------------------

Ship it!


Ship It!

- Raphael Kubo da Costa


On Jan. 5, 2012, 7:35 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103633/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 7:35 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> As seen in bug 289671, "kdf" aborts (crashes) when the "df" output does not start with "Filesystem". The error message from gvfs is marked as WONTFIX in upstream bug trackers, so we have to deal with those messages.
> 
> The proposed patch skips any leading messages, and only aborts when no "Filesystem" string could be found.
> 
> 
> This addresses bug 289671.
>     http://bugs.kde.org/show_bug.cgi?id=289671
> 
> 
> Diffs
> -----
> 
>   disklist.cpp dbaf49c 
> 
> Diff: http://git.reviewboard.kde.org/r/103633/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120109/45f74499/attachment.html>


More information about the Kde-utils-devel mailing list