Review Request: use FileSize type for humanReadableSize() parameter

[Martin Tobias Holmedahl Sandsmark]

> On Jan. 5, 2012, 4:53 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Ship It!
> 
> Anssi Hannula wrote:
>     I don't have KDE write access, I'm just an occasional contributor.

Applied in c8d6b5af05ef23f7b450809f94ac65f6225e9d87, I think you need to close it.

Thanks a lot :-)


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102870/#review9577
-----------------------------------------------------------


On Dec. 21, 2011, 7:36 p.m., Anssi Hannula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102870/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 7:36 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Filelight internally uses a FileSize type in fileTree.h to represent
> file sizes. However, File::humanReadableSize() takes the size as uint
> instead of FileSize, causing overflow issues if FileSize is defined
> as larger than uint.
> 
> 
> Diffs
> -----
> 
>   src/part/fileTree.h fe0a9ec 
>   src/part/fileTree.cpp 6da7a8f 
> 
> Diff: http://git.reviewboard.kde.org/r/102870/diff/diff
> 
> 
> Testing
> -------
> 
> Built filelight in kdeutils-4.6.5 and git master with this change and it caused no issues.
> 
> 
> Thanks,
> 
> Anssi Hannula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120105/8d8d9239/attachment.html>