Review Request: enhance performance at updating KWallet Editor Tree

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105633/#review17333
-----------------------------------------------------------


I'm really sorry for not saying anything so far, I'm not familiar with this code base so I thought it'd be better for someone else to comment. Meanwhile, dfaure has pushed a fix for bug 279161. Is there any part of this review request that still applies?

- Raphael Kubo da Costa


On July 21, 2012, 1:20 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105633/
> -----------------------------------------------------------
> 
> (Updated July 21, 2012, 1:20 p.m.)
> 
> 
> Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> I have > 340 entries in "Form Data" in the wallet. When opening the wallet editor, it takes about 9 Seconds until the tree is displayed!
> I investigated the problem and found out that this is due to 2 reasons:
> 1.) The list of entries is checked against existing entries in the tree, which is done by linear search in the given entries list and in the tree
>     which results in a quadratic complexity.
> 2.) unneeded duplicate dbus calls
> 
> I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a duplicate, unneeded query over dbus
> 
> 
> This addresses bugs 279161 and 284671.
>     http://bugs.kde.org/show_bug.cgi?id=279161
>     http://bugs.kde.org/show_bug.cgi?id=284671
> 
> 
> Diffs
> -----
> 
>   allyourbase.h d3452cd 
>   allyourbase.cpp f57eb68 
>   kwalleteditor.cpp 777ce8d 
> 
> Diff: http://git.reviewboard.kde.org/r/105633/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120813/99e38767/attachment.html>