Review Request: KCalc Backspace Button

[Raphael Kubo da Costa]

> On April 17, 2012, 4:37 p.m., Evan Teran wrote:
> > I've actually already added a backspace button the the 4.8 branch in GIT. So I'm going to have to reject this patch. However, you used a much better icon for the button, so I'll be using that for the button text :-).

Technically you should coordinate with the translation team first, since this changes a translatable string, right?


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104604/#review12586
-----------------------------------------------------------


On April 15, 2012, 10:19 a.m., Reshad Patuck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104604/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 10:19 a.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Description
> -------
> 
> Added a backspace button to KCalc so as to make it easier when using the mouse to enter data.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=204782.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=204782
> 
> 
> Diffs
> -----
> 
>   kcalc.h 38b3036 
>   kcalc.cpp 9cfdfcf 
>   kcalc.ui 4f2f1e5 
>   kcalcdisplay.h 84c1908 
>   kcalcdisplay.cpp fdc1140 
> 
> Diff: http://git.reviewboard.kde.org/r/104604/diff/
> 
> 
> Testing
> -------
> 
> Unit testing on the backspace buttons functionality, Integration testing when using it along with multiple other functions.
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://git.reviewboard.kde.org/r/104604/s/534/
> 
> 
> Thanks,
> 
> Reshad Patuck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120417/717ec88b/attachment.html>