Review Request: Changing conflicting accel keys

Evan Teran eteran at alum.rit.edu
Tue Apr 10 20:28:31 UTC 2012


I'm not sure what the procedure for these review requests is, so I just
downloaded the diff, it looks reasonable and applied the patch to the 4.8
branch.

If there is a simpler/better way, please let me know.

Evan

2011/11/27 Eike Krumbacher <eike.krumbacher at x-eike.de>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103254/
>   Review request for KDE Utils, Evan Teran and Funda Wang.
> By Eike Krumbacher.
>
> *Updated Nov. 27, 2011, 7:08 p.m.*
> Changes
>
> * Diff is now just &Constants Buttons --> Constants &Buttons
> * Added fwang
>
>   Description
>
> Hi!
>
> In KCalc, there are some entries with the same accelerator key. There is:
> * Settings->&Configure
> * Menu->&Constants
> * Settings->&Constants Button
>
> I changed them to:
>
> KCalcConstMenu(i18n("Constan&ts")
> setText(i18n("Constants &Buttons")
>
> Leaving Settings->Configure as it is. This one is derived from kdelibs.
>
> It might not be needed, to change Menu->Constan&ts, but I did it anyway.
>
> Hope you like
>
> Eike
>
>   Testing
>
> Trying out all Accelerator keys. Works for me.
>
>   *Bugs: * 242238 <http://bugs.kde.org/show_bug.cgi?id=242238>
> Diffs (updated)
>
>    - kcalc.cpp (d7a943b)
>
> View Diff <http://git.reviewboard.kde.org/r/103254/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20120410/19912d20/attachment.html>


More information about the Kde-utils-devel mailing list