Review Request: lha archive support

Mon Sep 26 11:54:14 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102682/
-----------------------------------------------------------

(Updated Sept. 26, 2011, 11:54 a.m.)

Review request for KDE Utils and Raphael Kubo da Costa.

Changes
-------

You are indeed correct. There shouldn't be an empty line, especially in the part of the listing that has the filenames. I removed that check and also removed the last option in the FileExistsInput stringlist.

Description
-------

Add support for lha archives.

This addresses bug 231896.
    http://bugs.kde.org/show_bug.cgi?id=231896

Diffs (updated)
-----

  app/ark.desktop 2c4e348 
  app/ark_dndextract.desktop 9dd2a59 
  app/ark_servicemenu.desktop 0341c7e 
  plugins/CMakeLists.txt e3cb9ec 
  plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
  plugins/clilhaplugin/cliplugin.h PRE-CREATION 
  plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
  plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102682/diff/diff

Testing
-------

Tested opening and modifying lha archives created using the lha utility from http://lha.sourceforge.jp/ and some archives from http://aminet.net

Thanks,

Theofilos Intzoglou

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110926/f5c328e3/attachment-0001.html>