Review Request: Kill process when no cancel option exists for a cli tool
Theofilos Intzoglou
int.teo at gmail.com
Mon Sep 26 11:24:05 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102702/
-----------------------------------------------------------
(Updated Sept. 26, 2011, 11:24 a.m.)
Review request for KDE Utils and Raphael Kubo da Costa.
Description
-------
When extracting an archive and a file exists, we are presented with 4 different options, however some cli tools don't have the option to cancel the extraction. Until now as I can see the only option would be to just autoskip when pressing cancel. This led to different results than what was expected (cancel extraction completely).
The patch attached adds a special response "KILL" that when is used from a plugin, the process is killed.
Diffs (updated)
-----
kerfuffle/cliinterface.h 09729c3
kerfuffle/cliinterface.cpp f187e1c
plugins/clizipplugin/cliplugin.cpp 8552562
Diff: http://git.reviewboard.kde.org/r/102702/diff/diff
Testing
-------
Thanks,
Theofilos Intzoglou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110926/be30e8c6/attachment.html>
More information about the Kde-utils-devel
mailing list