Review Request: Kill process when no cancel option exists for a cli tool

[Raphael Kubo da Costa]

> On Sept. 25, 2011, 6:03 p.m., Raphael Kubo da Costa wrote:
> > Could you please list what tools have problems with canceling the extraction in this case?
> 
> Theofilos Intzoglou wrote:
>     The lha and unzip tools don't present an option to quit the extraction process when a file already exists. Those two for now :-)

Alright. Checking for a specific string does not sound like a very clean approach. What if plugins just do not specify this last string, and when it is not present cliinterface calls doKill()?


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102702/#review6805
-----------------------------------------------------------


On Sept. 25, 2011, 6:16 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102702/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2011, 6:16 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> When extracting an archive and a file exists, we are presented with 4 different options, however some cli tools don't have the option to cancel the extraction. Until now as I can see the only option would be to just autoskip when pressing cancel. This led to different results than what was expected (cancel extraction completely).
> 
> The patch attached adds a special response "KILL" that when is used from a plugin, the process is killed.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.h 09729c3 
>   kerfuffle/cliinterface.cpp f187e1c 
> 
> Diff: http://git.reviewboard.kde.org/r/102702/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110925/25af92ed/attachment-0001.html>