Review Request: Bring karchive plugin in a better shape

Raphael Kubo da Costa rakuco at freebsd.org
Sun Oct 23 14:31:49 UTC 2011



> On Oct. 23, 2011, 2:16 p.m., Raphael Kubo da Costa wrote:
> > Ship It!

Meh, I had problems with closing the review automatically again. I've committed the patch as commit 1f79ee79c9078dd96e7e437519a00f08e6bf5570, can you close the review request? Thanks!


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102785/#review7551
-----------------------------------------------------------


On Oct. 23, 2011, 11:02 a.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102785/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 11:02 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> * Make karchive plugin compilable again
> * If there was a directory inside the archive the file size wasn't shown
> * Convert file permissions to a readable string
> 
> 
> Diffs
> -----
> 
>   plugins/karchiveplugin/karchiveplugin.h eb08de9 
>   plugins/karchiveplugin/karchiveplugin.cpp 330e002 
> 
> Diff: http://git.reviewboard.kde.org/r/102785/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111023/6f9df7d5/attachment-0001.html>


More information about the Kde-utils-devel mailing list