Review Request: Fix example cli plugin
Raphael Kubo da Costa
rakuco at freebsd.org
Tue Oct 11 13:04:07 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102784/#review7246
-----------------------------------------------------------
Thanks for the patch. I think we can improve it even further by splitting the class into a .h file and a .cpp file.
plugins/cliplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102784/#comment6306>
Please #include "kerfuffle/kerfuffle_export.h" explicitly to use this macro.
- Raphael Kubo da Costa
On Oct. 5, 2011, 2:21 p.m., Theofilos Intzoglou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102784/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2011, 2:21 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Description
> -------
>
> The example cli plugin needed some changes to be usable due to changes to the way the ark handles its plugins
>
>
> Diffs
> -----
>
> plugins/cliplugin/cliplugin.cpp e46853f
>
> Diff: http://git.reviewboard.kde.org/r/102784/diff/diff
>
>
> Testing
> -------
>
> Now the cliplugin is compilable without any warnings
>
>
> Thanks,
>
> Theofilos Intzoglou
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111011/c9107d70/attachment.html>
More information about the Kde-utils-devel
mailing list