Review Request: Changing conflicting accel keys

Eike Krumbacher eike.krumbacher at x-eike.de
Sun Nov 27 19:08:15 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103254/
-----------------------------------------------------------

(Updated Nov. 27, 2011, 7:08 p.m.)


Review request for KDE Utils, Evan Teran and Funda Wang.


Changes
-------

* Diff is now just &Constants Buttons --> Constants &Buttons
* Added fwang


Description
-------

Hi!

In KCalc, there are some entries with the same accelerator key. There is:
* Settings->&Configure
* Menu->&Constants
* Settings->&Constants Button

I changed them to:

KCalcConstMenu(i18n("Constan&ts")
setText(i18n("Constants &Buttons")

Leaving Settings->Configure as it is. This one is derived from kdelibs.

It might not be needed, to change Menu->Constan&ts, but I did it anyway. 

Hope you like

Eike


This addresses bug 242238.
    http://bugs.kde.org/show_bug.cgi?id=242238


Diffs (updated)
-----

  kcalc.cpp d7a943b 

Diff: http://git.reviewboard.kde.org/r/103254/diff/diff


Testing
-------

Trying out all Accelerator keys. Works for me. 


Thanks,

Eike Krumbacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111127/325475a1/attachment.html>


More information about the Kde-utils-devel mailing list