Review Request: Use user preferred application to preview files.

[Michal Sciubidlo]

> On Nov. 23, 2011, 10:25 p.m., Raphael Kubo da Costa wrote:
> > The patch as it stands ends up effectively disabling the preview dialog, which is a no-go -- calling KMimeTypeTrader::query() without specifying the service type will use "Application" as default and all files will be previewed externally (there is another bug for allowing a user to choose to view a file externally, but that's another issue).
> > 
> > The related bug is a tricky issue whose proper fix I still don't know -- see http://article.gmane.org/gmane.comp.kde.devel.core/59514

Why disabling preview dialog is no-go?
Now ark ignores kde and user settings. It's coincidence that kde default app is konqueror. When kde will change it as you suggested kde.devel.core ark will ignore it.


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103221/#review8431
-----------------------------------------------------------


On Nov. 23, 2011, 7:13 p.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103221/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 7:13 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Use user preferred application to preview files. For now user has to delete every read only kpart from list to use other application as defcault.
> 
> 
> This addresses bug 201162.
>     http://bugs.kde.org/show_bug.cgi?id=201162
> 
> 
> Diffs
> -----
> 
>   part/arkviewer.cpp 9bfd651 
> 
> Diff: http://git.reviewboard.kde.org/r/103221/diff/diff
> 
> 
> Testing
> -------
> 
> Set kate as default, rekonq as second. Result: file opened with kate.
> Set rekonq as default, kate as second. Result: file opened with rekonq.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111124/ef3296af/attachment.html>