Review Request: Cleaned up "simple mode", grouping buttons
Eike Krumbacher
eike.krumbacher at x-eike.de
Thu Nov 24 08:57:58 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103197/
-----------------------------------------------------------
(Updated Nov. 24, 2011, 8:57 a.m.)
Review request for KDE Utils.
Changes
-------
Uploaded a screenshot and the new diff without hardcoded fonts. Explicitly mentioned Evan Teran ("eteran").
Thanks
Eike
Description
-------
Hi!
This patch cleans up "simple mode". I rearranged some buttons and hide the leftmost column in this mode. X³ as a function is now in the column, where x², x^y and so on can be found. I think, it is now easier to find the functions. The rightmost colum with memory functions is hidden in this mode too.
Furthermore, I rearranged the order of highlighted buttons by pressing the tab-button. This patch is highly inspired by the mockup of the reporter of bug https://bugs.kde.org/show_bug.cgi?id=254369 .
I hope you enjoy
Eike
This addresses bug 254369.
http://bugs.kde.org/show_bug.cgi?id=254369
Diffs (updated)
-----
kcalc.h 38b3036
kcalc.cpp d7a943b
kcalc.ui 31778b9
Diff: http://git.reviewboard.kde.org/r/103197/diff/diff
Testing
-------
* Tested the tab order
* tested hide/show of modes
Screenshots (updated)
-----------
kcalc simple mode
http://git.reviewboard.kde.org/r/103197/s/343/
Thanks,
Eike Krumbacher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111124/da7dca83/attachment.html>
More information about the Kde-utils-devel
mailing list